On Mon, 2010-04-26 at 23:14 +0200, Jakub Hrozek wrote:
New patches are attached, comments are inline.
On 04/26/2010 05:54 PM, Martin Nagy wrote:
> On Fri, 2010-04-23 at 11:57 +0200, Jakub Hrozek wrote:
>> > [PATCH 1/2] Remove freed server_common entities from list
>> > We didn't hit this before as we never removed common entities. When
>> > using service requests, we remove the resolved fo_servers when we hit a
>> > timeout, so the server_common can be also removed.
> Nack.
> BTW, this might be a good opportunity to remove all the silly
> common->something = NULL; statements and instead use a memset().
>
That sounds too dangerous on a rc_alloc-ed structure, it might also zero
the reference counts, no? I've left these assignments explicitly
Oh, right, didn't realize that.
Ack for 0001.
> And lastly, since you added a substantial amount of code, please
add you
> name to the list of authors at the top of the file and add this year :)
>
done
Uh-huh, I wanted you to add the current year, not to bump it :) Oh well.
Ack for 0002.
Thanks.
Martin