URL:
https://github.com/SSSD/sssd/pull/5453
Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section and coverity
fixes
alexey-tikhonov commented:
"""
Hi,
there is a compilation warning:
```
../src/sss_client/pam_sss_gss.c:339:5: warning: ‘reply’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
339 | free(reply);
| ^~~~~~~~~~~
../src/sss_client/pam_sss_gss.c:328:14: note: ‘reply’ was declared here
328 | uint8_t *reply;
| ^~~~~
../src/sss_client/pam_sss_gss.c:270:11: warning: ‘reply_len’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
270 | upn = malloc(reply_len * sizeof(char));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/sss_client/pam_sss_gss.c:327:12: note: ‘reply_len’ was declared here
327 | size_t reply_len;
| ^~~~~~~~~
```
That's false positive but I think still better to suppress.
Otherwise ACK for the 2nd patch ("fix coverity issues").
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5453#issuecomment-758823747