On Wed, Jan 18, 2012 at 11:14:40AM +0100, Sumit Bose wrote:
On Wed, Jan 18, 2012 at 10:19:52AM +0100, Jakub Hrozek wrote:
> Unbreaks the LDAP provider.
I hope the following haven't been discussed before for sudo.
Just a general comment and maybe this is already planned for the sudo
integration.
We tried to avoid ifdef's in the main part of the code and
placed platform/version/feature specific functionality in separate
files, see e.g. src/util/sss_ldap.c, src/util/sss_krb5.c or
src/providers/ldap/sdap_fd_events.c. If possible I think it would make
sense to move sdap_sudo_setup_tasks() to sdap_sudo.c and try to move
other code in #ifdef BUILD_SUDO-#endif there as well.
bye,
Sumit
Not using ifdefs in the main part makes sense. I think Pavel was trying to
place the sudo setup task into the same place where the similar id setup
task is. Our plan was to get rid of ifdefs completely when the feature
gets out of the experimental stage.
But perhaps it would be nice to offer a --with-sudo config option even
when the feature is stable so that the build can be trimmed for users
who only need the basic pam and nss responders.
https://fedorahosted.org/sssd/ticket/1145
Thanks!