On (13/01/14 14:22), Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/13/2014 06:00 AM, Lukas Slebodnik wrote:
> ehlo,
>
> Attached patches fix warnings with compiler flag
> Wmissing-prototypes. In my opinion, it is better declare function
> with static modifier if function is not part of public API.
>
Patch 0001: Ack
This will necessitate an soname bump (in case you were unaware). Even
though they were not specified in the header, these symbols would have
been exported. That means you will need to adjust the version-info
accordingly.
I want to send patch with bumping version after review of all patches for
ding-libs.
API is not changed but ABI is changed. Even if this patch was not accepted
ABI would be changed by the version map symbol file (#2194).
Thank you for review.
LS