On (18/06/15 17:35), Sumit Bose wrote:
On Thu, Jun 18, 2015 at 05:09:22PM +0200, Jakub Hrozek wrote:
> On Thu, Jun 18, 2015 at 09:04:48AM +0200, Pavel Březina wrote:
> > >>Thank you for the review, new version attached.
> > >>
> > >>bye,
> > >>Sumit
> > >
> > >
> > >ACK
> >
> > Those patches needs to be pushed *after* cached object patches land in since
> > they depend on them -- even though they can be (wrongly) applied to master.
>
> Sorry, but the tests don't compile for me:
> /home/remote/jhrozek/devel/sssd/src/tests/sysdb-tests.c: In function
‘test_sysdb_search_user_by_cert’:
> /home/remote/jhrozek/devel/sssd/src/tests/sysdb-tests.c:5218:16: error: implicit
declaration of function ‘sss_base64_decode’ [-Werror=implicit-function-declaration]
> val.data = sss_base64_decode(test_ctx, TEST_USER_CERT_DERB64, &val.length);
> ^
> /home/remote/jhrozek/devel/sssd/src/tests/sysdb-tests.c:5218:14: warning: assignment
makes pointer from integer without a cast [-Wint-conversion]
> val.data = sss_base64_decode(test_ctx, TEST_USER_CERT_DERB64, &val.length);
not sure why I (and CI) don't see this, but
diff --git a/src/tests/sysdb-tests.c b/src/tests/sysdb-tests.c
index 6dd299b..522a44a 100644
--- a/src/tests/sysdb-tests.c
+++ b/src/tests/sysdb-tests.c
@@ -27,6 +27,7 @@
#include <sys/stat.h>
#include <sys/types.h>
#include "util/util.h"
+#include "util/crypto/sss_crypto.h"
#include "confdb/confdb_setup.h"
#include "db/sysdb_private.h"
#include "db/sysdb_services.h"
should fix it. Can you try?
Sumit,
try to build old version of patch on your machine with
additional compiler flag "-ftrack-macro-expansion=0"
I hope it helps.
LS