On Mon, 2011-12-19 at 16:10 +0100, Jan Zelený wrote:
> On Mon, 2011-12-19 at 09:27 +0100, Jan Zelený wrote:
> > > Patch 0001: Guarantee NULL-termination when reading the pidfile
> >
> > I think it would be better to use
> >
> > pid_str[len] = '\0';
> >
> > instead of
> >
> > pid_str[pidlen] = '\0';
>
> Good idea. Fixed.
>
> > > Patch 0002: Always set umask when using mkstemp()
> >
> > For the record, this does fix 12397 and not 12398 as it is claimed in the
> > patch. Would you please also include 12396 and 12398 to this patch?
>
> Done.
>
> Thanks for the review. New patches attached.
Ack to both
Pushed to master.