On Wed, Jul 23, 2014 at 07:14:42PM +0200, Sumit Bose wrote:
On Tue, Jul 22, 2014 at 06:43:56PM +0200, Jakub Hrozek wrote:
> On Thu, Mar 13, 2014 at 12:00:47PM +0100, Sumit Bose wrote:
> > On Wed, Mar 12, 2014 at 11:20:42PM +0100, Jakub Hrozek wrote:
> > > Hi,
> > >
> > > the attached two patches are not strictly related to tokenGroups
> > > processing, but it's very easy to reproduce the problem that way. The
> > > issue is only confusing DEBUG messages, but it has already cost me
> > > several hours in processing logs from an SSSD user, so I think a fix is
> > > due, at least for master.
> > >
> > > See the patches and the commit messages for more details.
> > as a first note, the second patch makes nestedgroups-tests fail because
> > sdap_idmap_domain_has_algorithmic_mapping() must be made available to
> > the test and sdap_idmap_ctx must be initialized.
> > But since this 'only' influences the tests I will run some tests with
> > the current version of the patches.
> > bye,
> > Sumit
> I completely forgot about these patches until I was doing cleanup of my
> git branches. Attached is a new revision..
sorry, I completely forgot, too. Patch looks good and didn't show issues
in my tests. ACK.
Thanks for the swift review, pushed to master: