Re: [SSSD] [PATCH] resolv: Do not try to free addrinfo in case of error

On Sat, 2014-05-17 at 19:38 +0200, Lukas Slebodnik wrote:

ehlo,

We should call freeaddrinfo only in situation if getaddrinfo succeeds. It is not specified in RFC2553 the behaviour of calling freeaddrinfo with the NULL argument. It is more portable to do not rely on undocumented behaviour of glibc.

http://www.ietf.org/rfc/rfc2553.txt [Page 28]

simple patch is attached.

LS

While the behaviour with the NULL argument is not explicitly spelled out, I don't see the RFC saying that the behaviour is undefined either.

Is there really any platform where a free* function would not be a noop?