On Mon, Jan 27, 2014 at 02:25:25PM +0100, Lukas Slebodnik wrote:
On (27/01/14 13:43), Pavel Reichl wrote:
>[snip]
>>
>> Can you also add '_' as prefix for output parameters into declaration.
>> We are not consistent in this and I cannot find this in coding style,
>> but it improves readability.
>>
>> LS
>
>Hello Lukas,
>
>thank you for your comment. New patch implementing your suggestion is
>attached.
>
>PR
>
>
>From 95560c8b33ad6b8efdce67b6098d5cdd88fb4129 Mon Sep 17 00:00:00 2001
>From: Pavel Reichl <preichl(a)redhat.com>
>Date: Sun, 26 Jan 2014 12:39:43 +0000
>Subject: [PATCH] utils: handling NULL params in sss_parse_name
>
>---
> src/util/usertools.c | 50 +++++++++++++++++++++++++++-----------------------
> src/util/util.h | 2 +-
> 2 files changed, 28 insertions(+), 24 deletions(-)
ACK
LS
Pushed to master.
If there are any calls to sss_parse_name() that only pass in the
parameter to have a valid output pointer, can you remove those in a
follow up patch?