URL:
https://github.com/SSSD/sssd/pull/30
Title: #30: sssctl: use systemd D-Bus API
jhrozek commented:
"""
On Wed, Sep 21, 2016 at 03:27:13AM -0700, Pavel Březina wrote:
If systemd is used we leverage it's D-Bus API instead of running
systemctl.
Resolves:
https://fedorahosted.org/sssd/ticket/3056
You can view, comment on, or merge this pull request online at:
https://github.com/SSSD/sssd/pull/30
-- Commit Summary --
* sssctl: use systemd D-Bus API
-- File Changes --
M Makefile.am (1)
M src/tools/sssctl/sssctl.c (23)
M src/tools/sssctl/sssctl.h (4)
-- Patch Links --
https://github.com/SSSD/sssd/pull/30.patch
https://github.com/SSSD/sssd/pull/30.diff
So far I just scrolled through the diff and it looks good to me. Can you
please add some DEBUG messages for both failure cases and some trace
messages so we can follow the code flow?
Additionally, should we call /sbin/service instead of service so that we
don't rely on $PATH?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/30#issuecomment-249141263