On 01/27/2016 05:11 PM, Pavel Reichl wrote:
On 01/27/2016 02:58 PM, Michal Židek wrote:
> On 01/22/2016 06:38 PM, Pavel Reichl wrote:
[snip]
>> first_rid += ctx->idmap_opts.rangesize;
>> @@ -631,6 +631,14 @@ get_helpers(struct sss_idmap_ctx *ctx,
>>
>> *_sec_slices = sec_slices;
>> return IDMAP_SUCCESS;
>> +
>> +done:
>
> You use this goto target only case of failure. Could you
> change it's name to 'fail'? Or alternatively you can refactor
> the function to have single exit point and keep the done label.
> Choice is yours.
>
OK, done.
Thanks.
ACK.
Link to CI:
http://sssd-ci.duckdns.org/logs/job/36/70/summary.html
Michal