On Tue, Oct 14, 2014 at 06:22:05PM +0200, Pavel Reichl wrote:
> On 10/13/2014 04:08 PM, Jakub Hrozek wrote:
>> Hi,
>>
>> I guess I can safely send another round of patches that were already
>> tested by Michal and me.
>>
>> The first patch adds new command line options --uid and --gid to all SSSD
>> servers, making it possible to switch to another user ID if needed. So
>> far all the servers still run as root.
>>
>> The other patches are trivial refactoring for unit tests (2 and 3). I
>> don't like the #ifdefs in server.c, but I couldn't think of another
>> way..
>>
>> The final patch is a unit test for server_setup, exercising different
>> options.
>>
>>
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel(a)lists.fedorahosted.org
>>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> I'm seeing this minor problem:
>
> ../../../../src/tests/cwrap/../../../src/util/domain_info_utils.c: In
> function ‘subdomain_enumerates’:
> ../../../../src/tests/cwrap/../../../src/util/domain_info_utils.c:77:9:
> error: ‘for’ loop initial declarations are only allowed in C99 mode
> for (int i=0; parent->sd_enumerate[i]; i++) {
> ^
> ../../../../src/tests/cwrap/../../../src/util/domain_info_utils.c:77:9:
> note: use option -std=c99 or -std=gnu99 to compile your code
> make[3]: *** [../../../src/util/server_tests-domain_info_utils.o] Error 1
I think your patch addresses a legitimate problem in the old code and
should be included separately. ACK to the patch. See the attached patchset..
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel