On (28/05/14 14:15), Jakub Hrozek wrote:
On Wed, May 28, 2014 at 11:37:50AM +0200, Jakub Hrozek wrote:
> On Wed, May 28, 2014 at 11:05:38AM +0200, Pavel Březina wrote:
> > On 05/28/2014 10:48 AM, Jakub Hrozek wrote:
> > >On Tue, May 27, 2014 at 10:28:42PM +0200, Pavel Březina wrote:
> > >>Hi,
> > >>I'm starting a new thread branch, since the review mails got kind
of
> > >>separated and it starts to be confusing.
> > >>
> > >>I'm sending new patch set including also Jakub's tests, all
issues
> > >>should be fixed.
> > >>
> > >>Ack to all Jakub's patches.
> > >
> > >Squash in the following patch to the ifp_domains code and I'll ack :-)
> >
> > Thanks. New patches are attached.
> >
>
> These work fine.
>
> ACK
..or not. Lukas found out that there are Coverity warnings. The attached
patches fix them.
problem are fixed.
From 9e8f12c809823f4b7399734005ede6d4547d0510 Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Wed, 28 May 2014 13:14:20 +0200
Subject: [PATCH] fixup for components
ACK
From 313623150e661105388af95c906488866236b97a Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Wed, 28 May 2014 14:11:54 +0200
Subject: [PATCH] Return dbus error if set
ACK
I also tested dbus methods and they work like a charm :-)
ListComponents(out ao components);
ListResponders(out ao responders);
ListBackends(out ao backends);
FindMonitor(out o monitor);
FindResponderByName(in s name,
out o responder);
FindBackendByName(in s name,
out o backend);
FindDomainByName(in s name,
out o domain);
ListDomains(out ao domain);
LS