On Thu, 2011-12-15 at 10:48 +0100, Jakub Hrozek wrote:
On Wed, Dec 14, 2011 at 01:37:47PM -0500, Stephen Gallagher wrote:
> On Wed, 2011-12-14 at 14:15 +0100, Jakub Hrozek wrote:
> > Thank you for the review. New patches are attached.
>
> Patch 0008:
>
> +static bool string_equal(bool cs, const char *s1, const char *s2)
> +{
> + if (cs) {
> + return strcasecmp(s1, s2) == 0;
> + }
> +
> + return sss_utf8_case_eq((const uint8_t *)s1, (const uint8_t *)s2)
> == EOK;
> +}
> +
>
>
> I'm pretty sure you wanted:
>
>
> + if (cs) {
> + return strcmp(s1, s2) == 0;
> + }
>
> not strcasecmp() there.
>
>
> Everything else looks good.
Stupid code reviews catching my carefully crafted backdoor..
On a serious note, thank you for catching that. New patches are attached.
Patches look good. I provided a scratch build to a user today who was
asking about it in #sssd. I'd like to wait on pushing until he gets back
to us tomorrow with some of his test results.