On 08/06/2013 10:20 AM, Lukas Slebodnik wrote:
On (05/08/13 15:24), Pavel Březina wrote:
>
https://fedorahosted.org/sssd/ticket/2001
>
> There is a bug in underlying resolv_sort_srv_reply(). It sometimes
> returns less servers than there is on the input. This seems to be
> related to configuration when two servers has the same priority and
> weight (0). I haven't found the root cause yet, I'll investigate
> more.
NACK
>From ab328b91f0bdd5168a5d09f3748e5b2091c085b0 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
> Date: Sat, 3 Aug 2013 01:02:02 +0200
> Subject: [PATCH 3/7] Add is_host_in_domain() util function
Tests failed with 3rd patch and last patch did not fix this.
FAIL: util-tests
============================================================================
Testsuite summary for sssd 1.10.93
============================================================================
# TOTAL: 30
# PASS: 29
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to sssd-devel(a)lists.fedorahosted.org
============================================================================
make[3]: *** [test-suite.log] Error 1
make[3]: Leaving directory `/dev/shm/sssd_build'
make[2]: *** [check-TESTS] Error 2
make[2]: Leaving directory `/dev/shm/sssd_build'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/dev/shm/sssd_build'
make: *** [check-recursive] Error 1
bash$ cat util-tests.log
Running suite(s): util
test_murmurhash3_random seed: 1375776937
95%: Checks: 20, Failures: 1, Errors: 0
../sssd/src/tests/util-tests.c:833:F:util:test_is_host_in_domain:0: Host:
example.com,
Domain:
child.example.com, Expected: 0, Got: 1
LS
Thanks. I switch from int to size_t after running the tests and it
caused troubles, because size_t is obviously unsigned.
New patches are attached.