On Thu, Nov 25, 2010 at 03:19:02PM +0100, Jakub Hrozek wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
https://fedorahosted.org/sssd/ticket/691
In this version of patch, I only allowed the fallback in Kerberos where
I also switched from TCP do UDP as the default search protocol.
The code is working as expected. We might want to change it when other
protocols as tcp and udp needs to be supported, because then it might
not make sense to fallback back to all other supported protocols, but
chances are that this will never happen.
But I think it is a good idea to document the changes in the man pages,
too. Especially the behaviour of the krb5 provider where there is a
fallback from udp to tcp and where the Kerberos library will always try
udp first independent of the result of the DNS SRV lookup.
Please tell me if you do not have a chance to extend the man pages. Then
I'll ACK the patch as it is and will add man page changes myself.
bye,
Sumit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkzucFYACgkQHsardTLnvCUXuwCg08MoP8n+C4HZ7Ur0DTvjpAnF
nJ0AnAsqw0PmyrHMyRfkAxj9mF5eEBpi
=yxq5
-----END PGP SIGNATURE-----