On 16.7.2014 04:16, William wrote:
On Tue, 2014-07-15 at 15:57 +0200, Jan Cholasta wrote:
> On 11.7.2014 03:35, William wrote:
>>
>>>
>>> Thanks. Could you please rename the option to
>>> "entry_cache_ssh_host_timeout", so that it's consistent with
the rest of
>>> the cache timeout options?
>>>
>>>> However, I can't quite work out how to access confdb
>>>>> inside of ipa_hostid.c when it calls sysdb_store_ssh_host.
>>>
>>> I guess you can store the value in sss_domain_info, like the rest of the
>>> cache timeouts. See confdb_get_domain_internal.
>>>
>>
>>>>
>>>> Helps if I attach the patch.
>>>
>>> It certainly does :)
>>>
>>
>> Again, I have taken your advice and implemented these changes. I don't
>> see any dbus related changes in my patch, so I hope that this is too
>> your requirements.
>
> I do see some dbus changes: src/responder/ifp/ifp_iface_generated.c
>
> As Pavel and Lukáš pointed out earlier, these changes should not be
> included in the patch, as they are a result of a bug in dbus codegen script.
>
>>
>> Any comments and advice welcome.
>
> The confdb argument in sysdb_store_ssh_host is not needed anymore.
>
Ignore that last patch, I messed up and didn't include a .h file. Here
is the fixed patch.
This new patch seems to be based on some older version of the patch, it
uses wrong option name, sysdb_update_ssh_host still has the confdb
argument, etc.
--
Jan Cholasta