-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/19/2014 05:18 PM, Lukas Slebodnik wrote:
On (19/02/14 22:03), Sumit Bose wrote:
> On Wed, Feb 19, 2014 at 09:04:48PM +0100, Lukas Slebodnik wrote:
>> On (19/02/14 12:37), Jakub Hrozek wrote:
>>> On Wed, Feb 19, 2014 at 12:02:23PM +0100, Jakub Hrozek
>>> wrote:
>>>>> I realized I made a mistake in the rebasing above. I
>>>>> fixed that and then needed to do another manual rebase of
>>>>> these patches atop it. These patches apply atop the
>>>>> "[SSSD] DEBUG macro refactoring v6" patches.
>>>>
>>>> These patches work for me, so ACK.
>>>
>>> Pushed to master.
>>
>> find_uid-tests failed with these patches on fedora20.
>>
http://kojipkgs.fedoraproject.org//work/tasks/8367/6548367/build.log
>
>
>>
Do you have additional patches in this build?
>
> /builddir/build/SRPMS/sssd-1.11.90-0.20140219.1816.git22a9323._temp.fc20.src.rpm
>
>
>
The git hash does not look like anything from master.
>
Yes, I was testing some patches.
> I started a koji build
>
http://koji.fedoraproject.org/koji/taskinfo?taskID=6549081 with
> current master (4cde267bec52ae1723a125d19439a5c75b47ebb7) which
> is working fine.
>
I tried one more time with master and koji works fine.
Unfortunately, I am able to reproduce it locally in mock :-(
I've seen that happen intermittently as well in mock and koji. I
suspect there may be a bug/race condition in sd_uid_get_sessions(),
but I can't reproduce it consistently (and the DEBUG error doesn't
seem to fire...)
A quick look at the code suggests that we're probably missing a
'return EOK' after '*result = false', though.
I'll run a couple tests and see if that fixes the issue...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iEYEARECAAYFAlMGB3IACgkQeiVVYja6o6PiVQCfXCC9SfkQPZ1EtS35TNvvDuRy
ElwAoI+AlJsTghZdFu15wNVRdMaz9GNy
=jVmw
-----END PGP SIGNATURE-----