On Mon, Jan 4, 2016 at 2:50 PM Lukas Slebodnik
<lslebodn(a)redhat.com> wrote:
> On (04/01/16 13:28), Sumit Bose wrote:
> >Hi and Happy New Year,
> >
> >this patch fixes an infinite loop which causes a OOM condition when
> >using the NFS plugin as reported in
> >https://fedorahosted.org/sssd/ticket/2909 .
> >
> >bye,
> >Sumit
>
> >From f05b3b3b41b45a7faf5b96e49e391dd5cd263c77 Mon Sep 17 00:00:00 2001
> >From: Sumit Bose <sbose(a)redhat.com>
> >Date: Fri, 18 Dec 2015 13:16:29 +0100
> >Subject: [PATCH] nfs idmap: fix infinite loop
> >
> >Resolves
https://fedorahosted.org/sssd/ticket/2909
> >---
> > src/sss_client/nfs/sss_nfs_client.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/src/sss_client/nfs/sss_nfs_client.c
> b/src/sss_client/nfs/sss_nfs_client.c
> >index
> 64cb67a8b75ec04c1d6fa03905f5427bbe6c1e82..8fd993005606a52217dc306f1816c3f88a283aa0
> 100644
> >--- a/src/sss_client/nfs/sss_nfs_client.c
> >+++ b/src/sss_client/nfs/sss_nfs_client.c
> >@@ -157,7 +157,7 @@ static int get_user_from_mc(char *name, size_t len,
> uid_t uid)
> > goto done;
> > }
> > buf = p;
> >- rc = sss_nss_mc_getpwuid(uid, &pwd, buf, BUF_LEN);
> >+ rc = sss_nss_mc_getpwuid(uid, &pwd, buf, buflen);
> > } while (rc == ERANGE);
> >
> > if (rc == 0) {
> >@@ -198,7 +198,7 @@ static int get_group_from_mc(char *name, size_t len,
> id_t gid)
> > goto done;
> > }
> > buf = p;
> >- rc = sss_nss_mc_getgrgid(gid, &grp, buf, BUF_LEN);
> >+ rc = sss_nss_mc_getgrgid(gid, &grp, buf, buflen);
> > } while (rc == ERANGE);
> >
> > if (rc == 0) {
>
> ACK,
>
> It's already used in similar functions in the same file
> get_uid_from_mc
> get_gid_from_mc
>
> LS
>
Hi guys,
I'm still alive and happy to see there are users for this plugin.
I ACK this too.
Cheers,
Noam