On Wed, Oct 24, 2012 at 10:57:15AM +0200, Sumit Bose wrote:
Thank you for your comments. I added the comments to the commits and
changed the approach used in patch 0007 which also made patch 0010
obsolete. All other patches are unchanged, but I had to add a few more.
The new patch 0014 just fixes a minor memory hierarchy issue. Patch
15-18 make sure we have a principle with the right case in the cache for
AD users.
[PATCH 01/18] subdomain-id: Generate homedir only for users not groups
Ack, just a note to self to fix a whitespace error
[PATCH 02/18] s2n: save user principal name of sub-domain user
Ack
[PATCH 03/18] pac responder: fix copy-and-paste error
Ack
[PATCH 04/18] sysdb: look for ranges in the parent tree
Ack. We should really add unit tests to every part of sysdb API one of
these days..
[PATCH 05/18] pac responder: use only lower case user name
Ack
[PATCH 06/18] pac responder: add user principal to cached user object
Ack
[PATCH 07/18] krb5_auth_send: check for sub-domains
Ack
[PATCH 08/18] sysdb: add sysdb_base_dn()
Ack
[PATCH 09/18] check_ccache_files: search sub-domains as well
Ack
[PATCH 10/18] Add replacement for krb5_find_authdata()
Ack
[PATCH 11/18] krb5_auth: check if principal belongs to a different realm
Ack
[PATCH 12/18] krb5_auth: send different_realm flag to krb5_child
Ack
[PATCH 13/18] krb5_child: send PAC to PAC responder
I'm not really happy about calling the responder from the child, but I
can't think of a better way either. So Ack :)
[PATCH 14/18] krb5_mod_ccname: replace wrong memory context
Ack
[PATCH 15/18] krb5_child: send back the client principal
I would prefer to use the new debug levels in new code. I can change
that before pushing, though. Othwerwise Ack.
[PATCH 16/18] Add new call find_or_guess_upn()
Ack, this is much cleaner, thank you.
[PATCH 17/18] Use find_or_guess_upn() where needed
Ack
[PATCH 18/18] krb5_auth: update with correct UPN if needed
Ack
I believe Simo's concerns were also addressed.