On (09/08/16 14:54), Jakub Hrozek wrote:
>On Tue, Aug 09, 2016 at 12:36:11PM +0200, Jakub Hrozek wrote:
>> On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote:
>> > On (13/07/16 17:48), Lukas Slebodnik wrote:
>> > >ehlo,
>> > >
>> > >attched patch is an integration test for regression #3093.
>> > >I prepared a test and I let someone else to fix it :-)
>> > >
>> > >I will try to find more bugs in downstream tests.
>> > >
>> > >BTW we might move test from test_ts_cache somewhere else.
>> > >But it was the fastest way how to write a test without enumeration.
>> > >
>> >
>> > As I previously wrote test_ts_cache is not the best place for this
>> > test. Attached are patches which some changes in intg tests.
>> > There is also test for grups with special characters
>> >
>> > LS
>>
>> Thank you, the only comment I have is that we should remove
>> ldap_auth_disable_tls_never_use_in_production option. We don't use it in
>> tests (we don't test authentication there at all at the moment) and it's
>> better to not advertise the option.
>>
I can remove it as part of "moving files" if you wish.
>> I'll give a formal ACK once the CI run finishes.
>
>For some reason, I can't get a 'green' CI run on RHEL-6. I tried three
>times, the last attempt is here:
>
http://sssd-ci.duckdns.org/logs/job/51/19/rhel6/ci-build-debug/ci-make-in...
>but all had the same errors.
>
>Did the patches change something in the way the server is set up on
>RHEL-6?
E SERVER_DOWN: {'desc': "Can't contact LDAP server"}
I have no idea why it should be stopped.
We do not stop openldap server. It should be done
only in cleanup (end of all tests in module)
It took me some time to find root of cause these failures.
The 1st patch fixes the issues. And i got a recomendation from
freeipa develoepers that it's better to avoid using destructors
for cleanup. With pytest we should use finalizers or
with keyword the same as for files.
LS