Title: #275: Implement access verification by rhost using ldap_access_order rhost option
@akamensky I've pushed some stylistic amendments to my github branch at
Mostly it's about line length and checking
all allocation results in tests against NULL. If you agree, can you squash the patches
prefixed with "SQ" into yours and resubmit?
I'm also running a Coverity scan and if that finishes clean, I'll ack (otherwise
I'll provide fixup patches because the Coverity instance is hosted internally at Red
And I have two more requests -- could you add an explicit statement to the manpage stating
that the `rhost` field is set by the application and the admin must check what the
application sends before enabling this test?
Finally, could you change the first line of the commit message to make it clearer what the
PR is about? Just something like "LDAP: Add support for rhost access control would
Thank you very much for your patience and persistence. I'm really impressed how you
tackled everything including unit tests.
See the full comment at https://github.com/SSSD/sssd/pull/275#issuecomment-337510450