On 08/02/2016 11:09 AM, Michal Židek wrote:
> Hi!
>
> When reviewing Petr's netgroup patch I found some issues
> with netgroups when using IPA provider.
>
> Attached patch fixes one of them.
>
> I filed ticket for the other issue here:
>
https://fedorahosted.org/sssd/ticket/3117
>
> Reviewing this is not priority for this week, but
> I already had the patch and wanted to put the
> list.
>
> Thanks,
> Michal
>
> 0001-ipa_netgroups-Lowercase-key-to-htable.patch
>
>
> From 2e5022452d7002e44ad17a59b4d5b12958721997 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek(a)redhat.com>
> Date: Thu, 28 Jul 2016 12:55:46 +0200
> Subject: [PATCH] ipa_netgroups: Lowercase key to htable
>
> Fixes:
>
https://fedorahosted.org/sssd/ticket/3116
>
> We lowercase the search key when storing
> entries into the hash table, but do not
> do it when we search for them. As a result
> we were not able to find netgroup by
> DN.
> ---
Hi Michal,
it looks good to me (aka LGTM).
I am waiting for CI.
ACK
And for test... I think you might file a ticket.
--
Petr^4 Čech