-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/30/2011 08:44 AM, Stephen Gallagher wrote:
On 03/29/2011 09:23 AM, Jan Zelený wrote:
> Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>> On 03/29/2011 03:53 AM, Jan Zelený wrote:
>>> I'm not entirely sure if I got the feature request right but in case I
>>> didn't I have already another patch prepared.
>>>
>>>
https://fedorahosted.org/sssd/ticket/700
>>
>> Nack.
>>
>> If we have explicitly set a principal, we should NOT fall back to NULL
>> on KRB5_KT_NOTFOUND.
>>
>> In krb5_child_setup(), I'd rather that you send fast_principal into
>> krb5_parse_name() and then get the realm from krb5_principal_get_realm().
> Fixed patch in attachment.
Ack
Sorry, Nack.
I just noticed one small bug: at line 1473 of krb5_child.c, you 'goto
failed' without setting kerr.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk2TJhYACgkQeiVVYja6o6MTWwCcC3ooxEbU/JGagZDZP51mXeQJ
WtQAniw5e/KOscFadxP/VM22z5wgQVuT
=e4z3
-----END PGP SIGNATURE-----