-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/14/2010 07:14 AM, Jakub Hrozek wrote:
I must have sent wrong patches or goofed a rebase because these
patches
were absolutely wrong (and there was a bug in the user processing
patches I'm almost certain I fixed).
Sorry about that, new patches attached.
Patch 0001: Ack.
Patch 0002: Nack
I'd rather you used sysdb_attrs_get_string() to get the SYSDB_NAME in
sdap_add_incomplete_groups().
strtol() is also not safe here, as gid_t is a uint32_t, which on 32-bit
platforms may require unsigned long.
Also, since it would be a very useful thing to have, please add a
function sysdb_attrs_get_ulong() and use that for getting the GID.
Otherwise this looks good.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAky3UJsACgkQeiVVYja6o6OUsgCeIJSDMdLusbwjG99/nLeDcask
3UsAn2aqFcCM2e4cL1iyIxlmLO3dbxTo
=d+TV
-----END PGP SIGNATURE-----