On 10/15/2012 03:34 PM, Michal Židek wrote:
This patch introduces use_talloc_logs function. After this function
is
called, talloc log messages are sended to DEBUG macro and shown in our
logs.
https://fedorahosted.org/sssd/ticket/1495
Patch is attached.
Michal
Hi,
I didn't do a comprehensive review yet, but I don't really like the way
you are using use_talloc_log(). I think it would be much better to
create a function (say debug_init()) that would take care of debug
initialization i.e. setting debug level and enabling talloc. It should
basically replace debug_convert_old_level() and
CONVERT_AND_SET_DEBUG_LEVEL() calls.
There are quite a few places where we are initializing our debug
facility so this would make it easier to maintain in the future.
The talloc logging itself looks al right, but can you prepend "talloc: "
before the message?
Thanks,
Pavel.