URL:
https://github.com/SSSD/sssd/pull/192
Title: #192: Add certificate mapping library
jhrozek commented:
"""
I won't pretend I read the certmap library code carefully, I more or less checked the
API, ran the tests and scrolled through the library code. My only concern there is the
memory allocations so that we don't grow the library memory context.
From functional side, the patches break D-Bus lookups by certificate for me. I didn't
see any other issues against a (legacy, considering this functionality) IPA 4.4 server.
I don't have any other comments except those in this review and the D-Bus lookups.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/192#issuecomment-288133351