On Thu, May 28, 2015 at 08:47:28AM -0400, Stephen Gallagher wrote:
On Fri, 2015-05-22 at 16:13 +0200, Jakub Hrozek wrote:
> On Thu, May 21, 2015 at 01:43:19PM +0200, Lukas Slebodnik wrote:
> > ehlo,
> >
> > There were some failed tests in ci log
> >
http://sssd-ci.duckdns.org/logs/job/12/67/fedora_rawhide/ci.html
> >
http://sssd-ci.duckdns.org/logs/job/14/07/fedora_rawhide/ci.html
> >
http://sssd-ci.duckdns.org/logs/job/14/97/debian_testing/ci.html
> >
> > Attached patch should fix race condition between two SSSDConfigTest
> > tests.
> > The problem is just in master due to python{2,3} changes.
> >
> > LS
>
> The intent is good, but I would prefer using the setUp() and
> tearDown()
> methods for creating and removing the directory. It's safe because
> the
> Python documentation says:
> If setUp() succeeded, the tearDown() method will be run whether
> runTest() succeeded or not.
It's ambiguous if there is an unhandled exception in the tests, isn't
it?
Normally an unhandled exception aborts the script completely. But that's
not special to test fixtures..