On 10 Mar 2017, at 10:52, Pavel Březina
<notifications(a)github.com> wrote:
@pbrezina commented on this pull request.
In src/responder/ifp/ifp_users.c
<
https://github.com/SSSD/sssd/pull/174#discussion_r105363567>:
> + "user [%d]: %s\n", ret,
sss_strerror(ret));
+ sbus_request_fail_and_finish(sbus_req, error);
+ return;
+ }
+
+ if (ret == EOK) {
+ ret = ifp_users_list_copy(list_ctx, result->ldb_result);
+ if (ret != EOK) {
+ error = sbus_error_new(sbus_req, SBUS_ERROR_INTERNAL,
+ "Failed to copy domain result");
+ sbus_request_fail_and_finish(sbus_req, error);
+ return;
+ }
+ }
+
+ list_ctx->dom = get_next_domain(list_ctx->dom, SSS_GND_DESCEND);
The intention here is to gather result from all domains, right? I implemented
search_all_domains plugin option for enumeration use case to allow cache_req to not stop
on the first domain with result but get result from all domains.This can be used in
ifp_users_list_by_name instead of iteration, we just need to switch the filter plugins to
this.
We can also use it for the method implemented here. cache_req needs small work though to
allow override plugin settings in similar way Fabiano did for PAM responder
(cache_req_data_set_bypass_cache).
Ok, @sbose, please let me know if you’d like to change that now or later. I’m fine either
way.
"""
See the full comment at