Thanks, patch set works for me now.
I have just a few last nitpicks.
user-find takes extra parameter but ignores it, I believe this is not user friendly as IMO
user will consider it to be a domain name.
Please consider expanding man page description for --domain option in commands user-find
and group-find.
+static int override_group_show(struct sss_cmdline *cmdline,
+ struct sss_tool_ctx *tool_ctx,
+ void *pvt)
+{
+ TALLOC_CTX *tmp_ctx;
+ struct override_group input = {NULL};
+ const char *dn;
+ char *anchor;
+ const char *filter;
+ int ret;
Please add empty line here.
+ tmp_ctx = talloc_new(NULL);
+ if (tmp_ctx == NULL) {
+ DEBUG(SSSDBG_CRIT_FAILURE, "talloc_new() failed.\n");
+ return EXIT_FAILURE;
+ }
+
+ ret = parse_cmdline_group_show(cmdline, tool_ctx, &input);
+ if (ret != EOK) {
Indentation.
+ DEBUG(SSSDBG_CRIT_FAILURE, "Unable to parse command
line.\n");
+ goto done;
+ }
+
+ ret = get_group_domain_msg(tool_ctx, &input);
+ if (ret != EOK) {
+ DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get object domain\n");
+ goto done;
+ }
+
+ ret = get_object_dn(tmp_ctx, input.domain, SYSDB_MEMBER_GROUP,
+ input.orig_name, NULL, &dn);
Indentation.
+ if (ret != EOK) {
+ DEBUG(SSSDBG_CRIT_FAILURE, "Unable to get object dn\n");
+ goto done;
+ }