URL:
https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
sumit-bose commented:
"""
Hi,
sorry for the delay. The code looks good and Coverity didn't find any new issues and
said the deadcode issue is solved.
Also the debug messages are looking better now. But after checking the original ticket
which asked for more specific debug messages I wonder if they can be improved even
further by
- adding a sss_log messages with the final error message to find_principal_in_keytab() as
well to make the reason why a keytab cannot be read (not exists, empty or other reason)
more clear
- if the default keytab is used to not just print 'default' in the debug/log
messages in select_principal_from_keytab() but the real path of the default keytab.
Please let me know what you think?
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/883#issuecomment-536455917