On 08/06/2012 08:57 PM, Simo Sorce wrote:
The major question I have is that this new code introduces O(N^2)
behavior, if there are more then a handful of groups it will be quite
costly. Can we find a way that is not so expensive ?
I think this is not a big problem. If I understand the code correctly,
the inner cycle only iterates through potential direct parent groups (we
add group member to them later) and it is unlikely to be a big number in
real scenarios (Or am I wrong? Is it common that a group has so many
direct parents that it would be expensive?).
I corrected the nitpicks, new patch is attached.
Thanks
Michal