On Mon, Jan 23, 2012 at 10:23:36AM +0100, Pavel Březina wrote:
Dne 23.1.2012 02:24, Stephen Gallagher napsal(a):
>Also, when you call sss_dp_issue_request(), you're passing 'state' as
>the pvt data for sss_dp_get_sudoers_msg(), but you meant to pass 'info',
>I think.
Shouldn't we start using tallog_get_type_abort() to detect these situations?
I'm not sure we should ever abort, except for situations like options
mismatch (those can be potentially very dangerous).
Also nack.
In sss_dp_get_sudoers_msg() you expect that info->name is set. But
it is not mandatory (e.g. when cn=defaults is requested). I suggest
sending empty filter when info->name is empty.
Correct, but as discussed off-list the downloading only cn=defaults
is going to be implemented with a new value of the "type" parameter to
sss_dp_get_sudoers_send(), so we should change the handling of info->name
when we implement this new type.