On 07/12/2016 11:54 AM, Jakub Hrozek wrote:
> On Tue, Jul 12, 2016 at 11:52:05AM +0200, Pavel Březina wrote:
>> On 07/12/2016 10:20 AM, Petr Cech wrote:
>>> Hello list,
>>>
>>> there is simple patch for [1].
>>>
>>> I prepared two version:
>>> a) the first is for changing the message,
>>> b) the second is for removing.
>>>
>>> I looked at the code -- I think it could be useful to know what type of
>>> direction we have. But I agree that it could be really confusing if we
>>> see 'trust direction not set'.
>>>
>>> So I vote for removing.
>>> Please do you have any other opinion?
>>>
>>>
>>> [1]
https://fedorahosted.org/sssd/ticket/3090
>>>
>>> Regards
>>
>> I think this is something that should not be removed. But we may move
>> it to
>> a higher debug level.
>>
>> I think a better message might be:
>> Trust type of [%s]: %s
>>
>> And in ipa_trust_dir2str() change "trust direction not set" to
"not
>> set".
>
> I haven't looked at the code in a long time, but my intent was to only
> print the message on the server, not the clients, because the trust
> direction is always not set for the clients and that's confusing people
> who review the logs.
We can print it only in server mode, i.e. id_ctx->sever_mode != NULL.
Hello,
thanks all for comments.
There is fixed patch attached.
Regards
--
Petr^4 Čech