-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/11/2010 09:58 AM, Jakub Hrozek wrote:
On 01/07/2010 05:54 PM, Stephen Gallagher wrote:
After a bit of thought, I decided to break this into two separate patches to make it more clear. New patches attached.
Patch 0002: Remove the explicit defaults where they're unneeded.
Ack
Patch 0003: Implement the mandatory flag as in the previous patch.
Nack,
the schema adds ipa_hostname as mandatory service.
Also all of the {access,auth,chpass,id}_providers are marked as mandatory - is that correct? A domain with just id and auth providers is a perfectly valid one.
In the LDAP config, I think plain ldap_search_base should be marked as mandatory, not the specialised ldap_{user,group}_search base - if these are not set, the value of ldap_search_base is used.
IIRC the krb5_realm and krb5_kdcip is not strictly mandatory when using the locator plugin, but I guess that the recommended use case would be to put the info into our config, so these are probably fine.
The code itself looks fine to me.
Jakub
I think I'm going to withdraw these patches for now. I think we probably need more fine-grained control on these options, such as "Mandatory, optional and advanced" (where ipa_domain might be optional, depending on whether or not the system is using DNS autodiscovery when we support it).
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/