On Wed, 2012-01-25 at 18:12 +0100, Sumit Bose wrote:
Hi,
a few days ago I send a draft patch where the sysdb context is stored
in the domain info struct. I created a patch which is a bot more
conservative than the last one and included the comments by Simo (added
a destructor and don't unconditionally add the context all the time).
This patch will make the handling of sub-domains much easier, because
now only the domain info struct for the sub-domains needs to be
up-to-date.
Nack.
To save ourselves some cycles, if we go through the search in
sysdb_get_ctx_from_list(), it would be best to assign the sysdb context
to the domain once it's discovered. That said, I'm confused why we would
ever hit that code. I'm somewhat inclined to remove it and just always
return the domain->sysdb value and see if anything blows up and fix that
instead.