On 11/02/2012 06:53 PM, Simo Sorce wrote:
On Thu, 2012-11-01 at 17:36 +0100, Pavel Březina wrote:
> + if (ctx->is_daemon && ctx->parent_pid > 0
> + && ctx->parent_pid == getppid()) {
> + if (ctx->parent_pid <= 0 || ctx->parent_pid != getppid())
> {
> + /* the parent process was already terminated */
> + DEBUG(SSSDBG_MINOR_FAILURE, ("Invalid parent pid
> \n"));
> + goto done;
> + }
> +
Isn't the second if condition redundant here ?
we can't even test it unless it is already true according to the
previous if () or am I missing something ?
Did you intend to use some || in the previous condition ?
Simo.
I'm sending a new set of patches. There are the three original and two new.
[1/5] fixes indentation in the whole server.c
[2/5] introduces a new debug level macro SSSDBG_IMPORTANT_INFO that
should be used instead of SSSDBG_FATAL_FAILURE on places where the
original level was 0, but it is not an error.