On 01/23/2013 11:21 AM, Ondrej Kos wrote:
> On 23/01/13 15:34, Dmitri Pal wrote:
>> On 01/23/2013 09:14 AM, Dmitri Pal wrote:
>>> On 01/23/2013 07:32 AM, Ondrej Kos wrote:
>>>> On 23/12/12 20:18, Dmitri Pal wrote:
>>>>> Patch 1
https://fedorahosted.org/sssd/ticket/766
>>>>> Patch 2
https://fedorahosted.org/sssd/ticket/1276
>>>>> Patch 3
https://fedorahosted.org/sssd/ticket/1246
>>>>> Patch 4
https://fedorahosted.org/sssd/ticket/1532
>>>>
>>>> [PATCH 1/4]
>>>>
>>>> just a nitpick,
>>>>> +enum ERR_LEVEL {
>>>>> + INI_STOP_ON_ANY = 0, /**< Fail if any problem is detected.
*/
>>>>> + INI_STOP_ON_NONE = 1, /**< Best effort - do not fail. */
>>>>> + INI_STOP_ON_ERROR = 2 /**< Fail on errors only. */
>>>>> +};
>>>> while using enum, it's unnecessary to enter values like this, when
the
>>>> variables are in row
>>> Yes, I know. It is just my paranoia. Since it was in the defines
>>> explicitly I carried it forward.
>>> The nice benefit is that you always know which one is the last without
>>> the need to go a mental exercise.
>>>
>>>> [PATCH 2/4]
>>>>
>>>> Ack
>>>>
>>>> [PATCH 3/4]
>>>>
>>>> Ack
>>>>
>>>> [PATCH 4/4]
>>>>
>>>> trailing whitespace errors
>>>> On 23/12/12 20:18, Dmitri Pal wrote:
>>>>> Applying: Replacing sprintf with sprintf
>>>>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:22: trailing
>>>>> whitespace.
>>>>>
>>>>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:203: trailing
>>>>> whitespace.
>>>>> printf("This is unexpected error %d in mode
%d\n",
>>>>> warning: 2 lines add whitespace errors.
>>>>>
>>>> Also, the patch name says "Replacing sprintf with sprintf",
shouldn't
>>>> it be "Replacing sprintf with snprintf" ?
>>> I will address that and resend.
>>>> Otherwise, it's an Ack
>>>>
>>>>
>>>> Ondra
>>>>
>>>>
>>>
>> I updated the 4-th patch and regenarated the whole remaining set.
>> All 8 outstanding patches are attached.
>>
>>
> Thanks, i was already looking on the second patchset. So to have it
> all in one place:
>
> [PATCH 1/8] : *Ack*
>
> [PATCH 2/8] : *Ack*
>
> [PATCH 3/8] : *Ack*
>
> [PATCH 4/8] : *Ack*
>
> [PATCH 5/8] : trailing whitespace - i see it's fixed in patch 6, but
> it should be consistent between commits, could you please fix this?
>> Applying: Refactor interface a bit
>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:254: trailing
>> whitespace.
>> if ((error_level < INI_STOP_ON_ANY) ||
>> warning: 1 line adds whitespace errors.
>
> [PATCH 6/8] : *Ack*
>
> [PATCH 7/8] : new line at EOF
>> Applying: More interface refactoring
>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:224: new blank
>> line at EOF.
>> +
>> warning: 1 line adds whitespace errors.
> otherwise Ack
>
>
> [PATCH 8/8] : *Ack*, just git complains about spaces, wich, as i
> understand, are for the testing purpose.
>> Applying: Unit test for parsing flags.
>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:28: space before
>> tab in indent.
>> tab_and_space = value
>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:29: space before
>> tab in indent.
>> space_and_tab = value
>> /home/okos/devel/ding-libs/.git/rebase-apply/patch:30: new blank line
>> at EOF.
>> +
>> warning: 3 lines add whitespace errors.
>
> Ondra
>
Patches again. I touched only 5 & 7.
I left 8 as is intentionally.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Ack
Pushed to master
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1013 Brno 1 office
irc: okos @ #brno