On 05/10/2016 01:31 PM, Pavel Březina wrote:
On 05/02/2016 03:02 PM, Petr Cech wrote:
> On 04/28/2016 01:39 PM, Pavel Březina wrote:
>> Hi, just few nitpicks:
>>
>> Patch 1 NEGCACHE: Adding timeout to struct sss_nc_ctx
>>
>>> +int responder_get_neg_timeout_from_confdb(struct confdb_ctx *cdb,
>>> + uint32_t *neg_timeout)
>>> +{
>>> + int value;
>>> + int ret = EOK;
>>
>> Please, use errno_t instead of int as a type of return code. And also do
>> not initialize it with declaration (especially not to EOK), it tends to
>> hide issues where you forget to set ret (I know it is not this case, but
>> it is a bad habit).
>>
>>> neg_timeout
>>
>> I think ncache_timeout would be a better name to use throughout the code
>> since we shortcut "negative cache" to ncache all over the code and you
>> remove most of neg_timeout names in following patches.
>
> Hi Pavel,
>
> I addressed all nitpicks. Patches are attached.
>
> Regards
Ack. CI has been running for hours... if it ever finishes I'll send the
result.
CI
http://sssd-ci.duckdns.org/logs/job/43/05/summary.html