On 09/11/2015 05:24 PM, Lukas Slebodnik wrote:
> --- a/src/providers/ipa/ipa_hbac.exports
> >+++ b/src/providers/ipa/ipa_hbac.exports
> >@@ -1,4 +1,4 @@
> >-IPA_HBAC_0.0.1 {
> >+IPA_HBAC_0.0.2 {
> >
> > # public functions
> > global:
> >@@ -8,6 +8,7 @@ IPA_HBAC_0.0.1 {
> > hbac_error_string;
> > hbac_free_info;
> > hbac_rule_is_complete;
> >+ hbac_enable_debug;
This change is not correct.
new functions should not be added to the the existing version
which was released.
You also forgot to update version-info for library.
@see more details about version script files in the thread which
introduced them to sssd
https://lists.fedorahosted.org/pipermail/sssd-devel/2014-July/019693.html
On Thu, Jun 26, 2014 at 10:31:27AM +0200, Lukas Slebodnik wrote:
> >ehlo,
> >
> >attached patch fixes ticket #2194.
> >
> >If you wan to know more about version script (version maps) here are links:
> >
> >http://people.redhat.com/drepper/dsohowto.pdf
> > (sections 2.2.5 .. 2.2.7, 3.4, 3.5)
> >https://www.gnu.org/software/gnulib/manual/html_node/LD-Version-Scripts.html
> >ftp://ftp.gnu.org/old-gnu/Manuals/ld-2.9.1/html_node/ld_25.html
BTW all these links were provided off the lists few weeks ago.
and for symplification attached is a patch which shoudl be squashed
to your 2nd patch:-)
LS
Hello Lukas,
thanks for comment and for patch too. I attached fixed patch.
Petr
0001-squash_me.patch
From 4246d5cd91c4c34b8524be5bfce38c57163a6e2b Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik<lslebodn(a)redhat.com>
Date: Fri, 11 Sep 2015 17:04:58 +0200
Subject: [PATCH] squash_me
---
Makefile.am | 2 +-
src/providers/ipa/ipa_hbac.exports | 8 ++++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 851f943a4c57b70cee4f4f34e83457e7d204aff1..a2a868455f91fac212fcfa7b41681086145c06f9
100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -928,7 +928,7 @@ libipa_hbac_la_LIBADD = \
$(UNICODE_LIBS)
libipa_hbac_la_LDFLAGS = \
-Wl,--version-script,$(srcdir)/src/providers/ipa/ipa_hbac.exports \
- -version-info 0:1:0
+ -version-info 1:0:1
Lukas, are you sure this version number 1:0:1? If
you're really sure
this number, I have not understood it properly.
dist_noinst_DATA += src/providers/ipa/ipa_hbac.exports
diff --git a/src/providers/ipa/ipa_hbac.exports b/src/providers/ipa/ipa_hbac.exports
index 63b6a5cd673d7b7f3096794648483d280a6bb47f..b7945e139b9ab81b7c1d68eb707acaaff7163a2e
100644
--- a/src/providers/ipa/ipa_hbac.exports
+++ b/src/providers/ipa/ipa_hbac.exports
@@ -1,4 +1,4 @@
-IPA_HBAC_0.0.2 {
+IPA_HBAC_0.0.1 {
# public functions
global:
@@ -8,9 +8,13 @@ IPA_HBAC_0.0.2 {
hbac_error_string;
hbac_free_info;
hbac_rule_is_complete;
- hbac_enable_debug;
# everything else is local
local:
*;
};
+
+IPA_HBAC_0.1.0 {
+ global:
+ hbac_evaluate;
+} IPA_HBAC_0.0.1;
--