On Wed, May 14, 2014 at 09:42:53AM +0200, Lukas Slebodnik wrote:
>@@ -398,7 +397,9 @@ be used by Python applications.
> Summary: The D-Bus responder of the SSSD
> Group: Applications/System
> License: GPLv3+
>+BuildRequires: augeas-devel
> Requires: sssd-common = %{version}-%{release}
>+Requires: augeas-libs
It is not necessary, but it does not hurt :-)
rpm can detect libuaugeas without it.
I am fine with adding dependency explicitly
sh$ rpm -q -p sssd-common-1.11.90-0.fc20.x86_64.rpm --requires | grep aug
sh$ rpm -q -p sssd-dbus-1.11.90-0.fc20.x86_64.rpm --requires | grep aug
libaugeas.so.0()(64bit)
libaugeas.so.0(AUGEAS_0.1.0)(64bit)
libaugeas.so.0(AUGEAS_0.8.0)(64bit)
> %description dbus
> Provides the D-Bus responder of the SSSD, called the InfoPipe, that allows
>@@ -574,7 +575,6 @@ rm -rf $RPM_BUILD_ROOT
> %{_libdir}/%{name}/libsss_debug.so
> %{_libdir}/%{name}/libsss_ldap_common.so
> %{_libdir}/%{name}/libsss_util.so
>-%{_libdir}/%{name}/libsss_config.so
>
> # 3rd party application libraries
> %{_libdir}/sssd/modules/libsss_autofs.so
>@@ -670,6 +670,7 @@ rm -rf $RPM_BUILD_ROOT
> %{_mandir}/man5/sssd-ifp.5*
> # InfoPipe DBus plumbing
> %{_sysconfdir}/dbus-1/system.d/org.freedesktop.sssd.infopipe.conf
>+%{_libdir}/%{name}/libsss_config.so
>
> %files client -f sssd_client.lang
> %defattr(-,root,root,-)
>--
>1.7.11.7
>
I think Jakub's comments are addresed.
ACK
LS
I would actually prefer to omit the explicit dependency, that's what the
Fedora Packaging Guidelines suggest as well. I verified that even
without the explicit deps, RPM does its job:
rpm -q --requires -p
/dev/shm/sssd/rpmbuild/RPMS/x86_64/sssd-dbus-1.11.90-0.fc20.x86_64.rpm | grep aug
libaugeas.so.0()(64bit)
libaugeas.so.0(AUGEAS_0.1.0)(64bit)
libaugeas.so.0(AUGEAS_0.8.0)(64bit)
OK if I push the attached patchset (just the dependency is removed) ?