Re: [SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

On Fri, May 23, 2014 at 05:03:35PM +0200, Lukas Slebodnik wrote:

...

...

Is this preparation for further patches?

Yes. This dependency was introduced in commit: commit b1c4a998f8e217b4ba4cd632f5069d479211c22d Author: Yassir Elley yelley@redhat.com Date: Wed May 21 19:58:52 2014 -0400

   AD-GPO: add libsmbclient to makefiles

   Reviewed-by: Sumit Bose <sbose@redhat.com>

In the e-mail to the list, Yassir wrote: """ The attached patch adds libsmbclient to the makefiles, in preparation for adding libsmbclient calls to the gpo-smb code """

I was aware of this patch, but I didn't notice that is "in preparation for"

We should push Sumit's patch, because rpms cannot be built from current master.

LS

I just pushed it: db2ee5c24be0228cc73816ffaaa3252ed6359385