Stephen Gallagher <sgallagh(a)redhat.com> wrote:
On 09/03/2010 04:31 PM, Jan Zeleny wrote:
> Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>> if (be_is_offline(state->be_ctx)) {
>>
>> /* Ok, we're offline. Return from the cache */
>>
>> - ret = sdap_access_decide_offline(req);
>> + sdap_access_decide_offline(req);
>>
>> goto finished;
>>
>> }
>>
>> Please add ret = EOK before 'goto finished'. While it just happens to
be
>> true right now, I'd rather we kept this explicit here, in case we ever
>> add something above this that changes ret.
>
> That would create dead assignment and this patch should eliminate them
> rather than create new ones. I would agree with you if the ret value was
> used after "finished" label, but this isn't the case. I just want to
be
> sure about this.
You are correct. I misread the "finished" label.
Based on previous comments I updated the patch.
--
Jan