URL:
https://github.com/SSSD/sssd/pull/152
Title: #152: Add a tevent wrapper around libcurl's asynchronous interface
jhrozek commented:
"""
I squashed one last trivial change that just checks the return value of the option set:
```
diff --git a/src/util/tev_curl.c b/src/util/tev_curl.c
index b966a78..233ad2c 100644
--- a/src/util/tev_curl.c
+++ b/src/util/tev_curl.c
@@ -832,6 +832,12 @@ static errno_t tcurl_set_options(struct tcurl_http_state *state,
crv = curl_easy_setopt(state->http_handle,
CURLOPT_INFILESIZE_LARGE,
sss_iobuf_get_size(state->inbuf));
+ if (crv != CURLE_OK) {
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Failed to set CURLOPT_INFILESIZE_LARGE [%d]: %s\n",
+ crv, curl_easy_strerror(crv));
+ return EIO;
+ }
ret = tcurl_set_read_options(state);
if (ret != EOK) {
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/152#issuecomment-286354583