-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/13/2009 10:02 AM, Martin Nagy wrote:
Shouldn't you also check here if ctx->name is not
"proxy" and the confdb
parameter "libName" isn't set to "files"? I'm not 100% sure,
but it
seems to me, that if you have this in your sssd.conf:
provider = proxy
libName = files
then ctx->name will still be set to "proxy" and your test in
get_domain_type() will fail.
Yes, this patch would break backwards compatibility (as well as setting
provider=proxy; libName=files manually), in tools, which is not great.
So I've left the old way of detecting legacy local domain in
get_domain_type() for domains that are defined in the old way.
Also, I think it would be nice if you documented this shortcut in
server/man/sssd.conf.5.xml and server/examples/sssd.conf.
Done.
New patch attached.
Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkqD9RcACgkQHsardTLnvCWLmACgjsXWE4paUunlcLteji/fEG05
Pn0An0dumuQ9PnfugWUYcacPkuoA1Ny8
=gp1C
-----END PGP SIGNATURE-----