On 01/07/2014 04:53 PM, Jakub Hrozek wrote:
On Tue, Jan 07, 2014 at 03:31:50PM +0200, Nikolai Kondrashov wrote:
> On 01/07/2014 02:33 PM, Jakub Hrozek wrote:
>> [PATCH 3/8] Remove extra flushing from debug message output
>> The code is fine, but why is it a separate patch and not part of #2 ? It
>> seems the issue was introduced in patch 2/8, right?
> No, it was there before my changes, in the original "debug_fn" function,
> body was moved to the new "debug_vprintf". That's why I kept it
> However, please squash it, if you think it's right.
Ah, sorry, my review was flawed. You're right.
Nevertheless, I think I found one bug in patch #2 when testing Stephen's
follow-up patches. I don't think it's correct to replace all occurences
of DEBUG_MSG with debug_fn. The reason is that DEBUG_MSG used to perform
check if a particular level is set, debug_fn prints directly.
One example of where we need to check the debug level is
ldb_debug_messages(), with the current version of the patch, the ldb
messages are always printed.
You're right. This is a regression. I forgot to update that when I moved the
level limiting back to the macro. Will fix.