On Wed, Apr 09, 2014 at 03:53:59PM +0200, Michal Židek wrote:
On 04/07/2014 10:23 AM, Jakub Hrozek wrote:
>On Fri, Apr 04, 2014 at 06:30:40PM -0400, Pavel Reichl wrote:
>>Or you could write a wrapper function 'diff_string_lists_const' calling
original 'diff_string_lists' but at least hiding the nasty discard_const_p.
>
>Do we have the discard_const hack used anywhere else than the AD
>provider enumeration? If not, then I would just close the ticket. If
>there are more occurences, the wrapper might help.
>
The discard_const hack is used on a lot of places in SSSD code, but
with this particular function it appears only in ad provider code
(and
tests).
I do not like the wrapper functions idea, because, as Lukas said, we
would need 3 different functions.
I am closing the ticket now (feel free to reopen it if you think it
needs a fix -- probably the fix will be 3 wrapper functions with
ugly suffixes :) ).
Michal
Fine by me.