-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/17/2010 04:33 PM, Sumit Bose wrote:
> On Wed, Nov 17, 2010 at 10:08:13PM +0100, Sumit Bose wrote:
>> On Thu, Nov 11, 2010 at 09:05:57AM -0500, Stephen Gallagher wrote:
> Previously, there was a race-condition where the monitor might
> terminate before its children.
>
> Resolves
https://fedorahosted.org/sssd/ticket/555
>>>
>>> ACK
>>>
>>> bye,
>>> Sumit
>
>> sorry, I have missed
>
>> src/monitor/monitor.c:1178:13: warning: 'error' may be used
>> uninitialized in this function
>
>> I only see this with -02, so the optimizer id doing some magic here. I
>> would suggest to error=0 at the beginning of the HAVE_GETPGRP block.
Ah, with -O2 it's unrolling the loop, and it realizes that there's a
chance that mt_ctx->svc_list could be empty, and therefore error would
never be set. In practice, this is likely impossible, but I have no
problems with shutting up the warning.
New patch attached.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkzlHhoACgkQeiVVYja6o6OMDgCeL7YDEQYjiysm5jQVFoOm4ODN
YaEAn1ecxMRG+vuQ+Dh9g/aFmlsvxeeK
=aFtc
-----END PGP SIGNATURE-----