On 02/12/2016 11:00 AM, Lukas Slebodnik wrote:
On (11/02/16 12:43), Pavel Březina wrote:
> On 02/10/2016 01:14 PM, Pavel Reichl wrote:
>> On 02/10/2016 12:50 PM, Pavel Březina wrote:
>>> On 02/10/2016 12:44 PM, Pavel Reichl wrote:
>>>>
>>>>
>>>> On 02/10/2016 11:38 AM, Pavel Březina wrote:
>>>>
>>>>>
>>>>> You can still use assertions in fixtures (I just checked with asn to
>>>>> be sure) and that is the way we should lean to. So forget error
codes
>>>>> and debug messages here, use assertions to make it cleaner and
shorter.
>>>>>
>>>>>>
>>>>
>>>> Thanks Pavel, can you please check if first version of the patch would
>>>> work for you?
>>>
>>> Yes, it works for me.
>>
>> Hello, I added types and made constants local to functions that use them
>> as Lukas and Pavel wished for. I also fixed the trailing '{' it the
>> function definition as Lukas pointed out.
>
> My intend was to keep TEST_2922_MIN/MAX_ID as a macro and the const's should
> be also declared as static, but let's not postpone this patch any longer.
> It's just a unit test anyway so it doesn't really matter.
>
> Ack from me.
Thank you for review and for ACK.
but would you be so kind and add also link to CI results.
No.
I have never seen such link from you :-)
If you do not know how to do it just ask me privately.
LS
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org