On (17/01/14 16:19), Lukas Slebodnik wrote:
>On (16/01/14 19:22), Dmitri Pal wrote:
>>On 01/13/2014 06:00 AM, Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> Attached patches fix warnings with compiler flag Wmissing-prototypes.
>>> In my opinion, it is better declare function with static modifier if
function
>>> is not part of public API.
>>>
>>> patch 0002-Use-static-modifier-for-unit-test-functions.patch helps me find
out
>>> that negative_test was not execupted as part of INI unit tests.
>>>
>>> 0004-REFARRAY-Move-declaration-of-ref_array_debug-to-priv.patch
>>> It is better to have declaration in private header file, beacuse it prevents
>>> copy&paste errors. Declaration in file ini/ini_valueobj_ut.c was wrong.
>>>
>>> The last patch enables extra compiler warnings including
Wmissing-prototypes.
>>>
>>> LS
>>>
>>>
>>> _______________________________________________
>>> sssd-devel mailing list
>>> sssd-devel(a)lists.fedorahosted.org
>>>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>I looked at the patches again. They seem fine.
>>I looks like collection has all the debug functions already exposed and
>>public.
>>
>>Let us make ref_array_debug public too as is. If it changes we will add
>>a different function. So far I do not see a reason for it to change.
>>
>>Does this simplify things?
>>
>
>I made ref_array_debug function public.
>
>Patch set is attached. but only 4th patch was changed.
>
>LS
Updated patchset is attached.
patch 1st-3rd are unchanged.
patch 4th is the same like in previous mail (it has not been reviewed yet)
patch 5th is new
patch 6th is updated.
LS